Getting that sweet, sweet approval
So, you found the perfect issue to work on, made a PR, and got the CI tests to succeed. What next? How do you get your contribution to be accepted and merged?
Well, core Apache Arrow developers, and possibly others who have a stake in the particular area of the Arrow libraries you’re modifying, will review your PR. To ensure a good review, keep the following in mind:
- Aside from passing existing unit tests, it’s expected that new functionality also adds new unit tests to ensure that it is properly tested.
- As much as possible, break your work into smaller single-purpose patches. It’s significantly more difficult to get a larger change with disjointed features merged.
- Follow the style guide for the library you’re modifying (more on that in the Finishing up with style! section next).
Once any feedback has been addressed and the PR is approved, one of the committers will merge your PR. Congratulations...