Reviewing the merge request – it’s about training, oversight, and reliability
Merge requests and code reviews are one of the most powerful ways to provide feedback to developers as they build code. Being one of the most valued ways to bring engineers to the next level, code reviews done by engineering leads and more than one, if possible, give engineers a chance to learn new techniques and technologies.
I have personally learned much from code reviews in my life, though, I thought the suggestion was more about style than content; it’s beneficial to learn new ways of doing things and, most importantly, keep your fellow developers happy by taking their suggestions. As an SRE, we often do impromptu code reviews or have to review code during an outage – and we don’t always like what we see, but it’s important to keep an open mind for style differences.
Avoiding the typical rubber stamp mentality
Merge requests are a chance to review the...